--

Thanks for the comment.

The term 'code smell' is Martin Fowler's, not mine.

I agree this example does not stink a lot.

It is a minor flaw.

I've written more than 120 code smells and many of them are canaries and elephant in a coal mine.

I don't like the wrong version because it is less readable and have Ifs.

But it is just my opinion

--

--

Maximiliano Contieri
Maximiliano Contieri

Written by Maximiliano Contieri

I’m a senior software engineer specialized in declarative designs. S.O.L.I.D. and agile methodologies fan. Maximilianocontieri.com

Responses (1)