Code Smell 90 — Implementative Callback Events
Published in
2 min readOct 7, 2021
When creating events, we should decouple the trigger from the action.
TL;DR: Name your functions acording to what happened.
Problems
- Observer Pattern violation
- Coupling
Solutions
- Name the events after “what happened”, not “what you should do”.
Sample Code
Wrong
const Item = ({name, handlePageChange)} =>
<li onClick={handlePageChange}>
{name}
</li>//handlePageChange is coupled to what you decide to do
//instead of what really happened
//
//We cannot reuse this kind of callbacks
Right
const Item = ({name, onItemSelected)} =>
<li onClick={onItemSelected}>
{name}
</li>//onItemSelected will be called just when a item was selected. KISS
//Parent can decide what to do (or do nothing)
//We defer the decision
Detection
This is a semantic smell. We can detect it on peer code reviews.
Tags
- Coupling
- Naming
Conclusion
Names are very important. We should delay implementation coupled names until the very last moment.
More Info
Credits
Photo by Ashim D’Silva on Unsplash
Thanks to Maciej for this tip
Beyond basic mathematical aptitude, the difference between good programmers and great programmers is verbal ability.
Marissa Mayer
This article is part of the CodeSmell Series.
