Code Smell 62 — Flag Variables

Flags indicate what happened. Unless their name is too generic.

Problems

• Readability
• Maintainability
• Coupling

Solutions

1. Use meaningful names
2. Try to avoid flags. They generate coupling.

Sample Code

Wrong

Right

Detection

We can search all the code for bad named flags.

Tags

• Readability

Conclusion

Flags are widespread on production code. We should restrict their usage and use clear and intention revealing names.

Relations

Code Smell 51 — Double Negatives

Code Smell 07 — Boolean Variables

More Info

Boolean flag

What exactly is a name? — Part II: Rehab

If you lie to the compiler, it will get its revenge.

Henry Spencer

Software Engineering Great Quotes

This article is part of the CodeSmell Series.

How to Find the Stinky parts of your Code