Code Smell 59 — Basic / Do Functions
sort, doSort, basicSort, doBasicSort, primitiveSort, superBasicPrimitiveSort, who does the real work?
Published in
2 min readJan 27, 2021
Problems
- Readability
- Bad Naming
- Low Cohesion
- Single Responsibility Principle
Solutions
- Use good object wrappers
- Use dynamic decorators
Sample Code
Wrong
Right
Detection
We can instruct our static linters to find wrapping methods if they follow conventions like doXXX(), basicXX() etc.
Tags
- Declarativeness
Conclusion
We came across this kind of methods some time in our developer life, We smelled something was not OK with them. Now is the time to change them!
More info
The primary disadvantage of Wrap Method is that it can lead to poor names. In the previous example, we renamed the pay method dispatchPay() just because we needed a different name for code in the original method.
Michael Feathers
This article is part of the CodeSmell Series.
